Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handling Update: Version Checking, ddev availability, ddev error codes #54

Closed
andrew-c-tran opened this issue Nov 17, 2017 · 3 comments
Milestone

Comments

@andrew-c-tran
Copy link
Contributor

Feature Request

With the introduction of JSON endpoints in the CLI, we need a version checking mechanism to error out when a < 0.9.4 version is detected as ddev list and ddev describe is critical for any sort of UI functionality. We've agreed that string parsing is fragile, and as such should not be supported.

What you expected to happen:

Discussion is needed on how to error out. This is a show stopper, text parsing of ddev-list and ddev-describe is to be completely removed. If an incompatible version is detected, how do we want to error out and show the customer? Do we simply show a warning and exit? Do we launch a browser window to ddev download site? etc.

Related source links or issues:

Initial version check discussion brought up in #18

@rfay rfay changed the title Error Handling Update: Version Checking Error Handling Update: Version Checking, ddev availability, ddev error codes Dec 28, 2017
@rfay
Copy link
Member

rfay commented Dec 28, 2017

This needs to handle many other cases as well:

  • ddev not available
  • ddev list fails (or any other command failure)

@andrew-c-tran
Copy link
Contributor Author

as of v0.2, the minimum version of ddev cli required by ddev-ui is now 0.11

@andrew-c-tran andrew-c-tran self-assigned this Jan 16, 2018
@andrew-c-tran andrew-c-tran added this to the v0.3.0 milestone Jan 16, 2018
@andrew-c-tran
Copy link
Contributor Author

to be addressed in #42 . closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants