Skip to content

Commit

Permalink
Remove com.ddev.container-type from documentation (#791)
Browse files Browse the repository at this point in the history
It is not needed any more to add this custom label to additional services
as ddev is using native com.docker.compose.service label
  • Loading branch information
tmotyl authored and tannerjfco committed Apr 24, 2018
1 parent 6cabb84 commit 37394e9
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions docs/users/extend/custom-compose-files.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ When defining additional services for your project, we recommended you follow th

- `com.ddev.app-url: $DDEV_URL`

- `com.ddev.container-type: [servicename]`

- Exposing ports for service: you can expose the port for a service to be accessible as `projectname.ddev.local:portNum` while your project is running. This is achieved by the following configurations for the container(s) being added:

- Define only the internal port in the `ports` section for docker-compose. The `hostPort:containerPort` convention normally used to expose ports in docker should not be used here, since we are leveraging the ddev router to expose the ports.
Expand Down

0 comments on commit 37394e9

Please sign in to comment.