Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove com.ddev.container-type from documentation #791

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

tmotyl
Copy link
Contributor

@tmotyl tmotyl commented Apr 17, 2018

PR #215 has changed the com.ddev.container-type label to
com.docker.compose.service.

Documentation https://ddev.readthedocs.io/en/latest/users/extend/custom-compose-files/
and solr example needs to be updated.

@tannerjfco
Copy link
Contributor

tannerjfco commented Apr 17, 2018

This is actually a label that was deprecated some time ago, and should be removed from the documentation. ddev uses the com.docker.compose.service label provided by docker-compose to determine the 'container type'.

@tmotyl tmotyl changed the title Add container-type label to solr example Add com.docker.compose.service label to solr example Apr 17, 2018
@tmotyl
Copy link
Contributor Author

tmotyl commented Apr 17, 2018

updated the issue description and PR to match comment from @tannerjfco

@tannerjfco
Copy link
Contributor

Thanks for the update! We actually don't need to define com.docker.compose.service anywhere though, as it's provided automatically by docker-compose to match the name of the service. If we just remove the label from the documented list of labels a custom service should provide, I think we'll be all set here. Sorry for the confusion, and thanks for the attention to this!

It is not needed any more to add this custom label to additional services
as ddev is using native com.docker.compose.service label
@tmotyl
Copy link
Contributor Author

tmotyl commented Apr 24, 2018

here you go

@tannerjfco tannerjfco changed the title Add com.docker.compose.service label to solr example Remove com.ddev.container-type from documentation Apr 24, 2018
Copy link
Contributor

@tannerjfco tannerjfco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the attention paid to this and the clean up

@tannerjfco tannerjfco merged commit 37394e9 into ddev:master Apr 24, 2018
@rickmanelius rickmanelius added this to the v0.18.0 milestone May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants