Add dark-mode supported sponsor logos on Github

[tyler36]

Is there an existing issue for this?

• I have searched the existing issues

Output of ddev debug test

Currently, some sponsor logos our Github homepage are barely readable or look strange.

Expected Behavior

Highlight our wonderful sponsors.

(image from ddev.com)

Actual Behavior

Steps To Reproduce

Visit: https://github.com/ddev/ddev#wonderful-sponsors

Anything else?

There were recent updates to https://ddev.com/ that fixed the issue there. We should be able to re-use those images.

[tyler36]

@Firesphere pointed it out the issue on Discord .

[rfay]

@bmartinez287 want to take a look?

[bmartinez287]

I will look into this. https://www.stefanjudis.com/notes/how-to-define-dark-light-mode-images-in-github-markdown/
the picture element should work nicely here.

[bmartinez287]

https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/quickstart-for-writing-on-github

[rpkoller]

+1 for opening the issue as well as the suggestion about the use of the picture element by @bmartinez287 . but the only detail i wonder about would it make sense to ask all the sponsors if they have variants of their logo for dark backgrounds (and in case they dont have if they are ok with the suggested inversion of colors done in the expected behavior screenshot). but some of the logos there couldnt be inverted and therefore fail WCAG SC 1.4.11 like agaric, the parenthesis of tag1, the heart of undpaul, the background square for centaros logo to name a few details.

[bmartinez287]

We could ask them after we replace them. In some cases, their reply might just be "it looks fine". Some logos prove a unique challenge since they are a single icon. But in most cases altering the SVG text seems to make it ally compatible.

We could ask them now, but this might be low in their priorities list so they might say yes but give us no timeframe for it.

[rpkoller]

yes i agree but i am just worried that some of them might have strict rules in regards of their corporate identity and changing colors in logos might alter that corporate identity therefore i think give them a headsup early on might be a good idea in any way.

[rfay]

The real problem here is that I'm going to be unwilling to bother them :)

[bmartinez287]

b3c1539
I'm not sure where the PR above hid those items. Searching for them does not bring them up in the repo. I can find the images folder where they are stored in the repo but not the definition for where they are placed to add the picture html tag.
Is ![DDEV featured sponsor logos] hidden behind some secure setting I need access to? @rfay

[rfay]

Those things come from ddev.com, 100% open source.

[bmartinez287]

I guess, I never seen the ...... ![something] syntax on markup. What is that called?

[rfay]

In markdown, that's how you insert an image.

[bmartinez287]