docs: adds a dark theme compatible svgs, fixes #5492 #5501 #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmartinez287
changed the title
|
I used the markdown lint VsCode plugin from David Anson to style the file so hopefully this covers that issue. |
|
If you're happy with it move it to "ready for review" and say when you think it can be pulled. I think https://github.com/ddev/ddev/blob/03abebadc08e5f8606c4fb74f9de9348fab269f1/README.md looks ok normal and also dark. |
|
It should be good to go now. |
|
Seems like it's working well this time around. Yay! |
|
Thanks for all your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
relates to #5501 #5492
The #gh-dark-mode-only and #gh-light-mode-only tags don't seem to be working so we are switching to the picture tag which is better since it would read correctly outside of github.
How This PR Solves The Issue
It switches from GitHub specific markdown language to the picture tag.