docs: adds a dark theme compatible svgs, fixes #5492 #5501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmartinez287
changed the title
bmartinez287
changed the title
bmartinez287
changed the title
bmartinez287
changed the title
bmartinez287
changed the title
|
Moved this to "draft" until the upstream PR gets merged. |
bmartinez287
changed the title
Modifies README.md to add the missing logos
bmartinez287
force-pushed
the
20231103_bmartinez287_ddev_main_readme_sponsors
branch
from
853f9bf
to
b4a5956
Compare
|
@rfay since the other one was merged this should be ready. |
|
Thanks! |
|
Looks like is adding both images. I will swap it for the picture tag. https://www.stefanjudis.com/notes/how-to-define-dark-light-mode-images-in-github-markdown/ |
|
Could you please fix https://github.com/ddev/ddev/actions/runs/6801051592/job/18491253628 markdownlint failure while you're working on it? Not sure where that came from, could be new version of markdownlint upstream. You'll need markdownlint-cli on your machine. |
rfay
pushed a commit
that referenced
this pull request
Nov 8, 2023
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies README.md to add the missing logos
However, it requires this PR to get merged first ddev/ddev.com#134
Otherwise, the sponsors will break on GitHub's dark theme. Due to the asset not being there.
Fixes #5492
Manual Testing Instructions
Check that the README sponsors load well on a light GitHub theme and a dark theme.
Release/Deployment Notes
No