New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When add new clause in query, it returns expression type, it's better to return a new query. #116

Closed

ttt-77 opened this issue Nov 28, 2023 · 0 comments · Fixed by #127

Assignees

Collaborator

ttt-77 commented Nov 28, 2023

For example,

aidb/aidb/query/query.py

Lines 523 to 526 in 9ae2dbe

    
           def add_select(self, expression, selects): 
        
             re = Rewriter(expression) 
        
             e = re.add_selects(selects) 
        
             return e.expression

ttt-77 self-assigned this

This was referenced Nov 28, 2023

Approximate selection #107

Merged

refactor query #127

Merged

ddkang linked a pull request

that will close this issue

refactor query #127

Merged

ddkang closed this as completed in #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment