-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issues in naming of cache table #21
Comments
A service can be used multiple times so it is not unique. I guess we can use a hash of the column names... |
Hashing is a great idea. I'll implement that. I am curious when can this case happen? i.e., a service being used multiple times but with different columns? Isn't inference service's input-output signature fixed? |
The HuggingFace example is a good one. We can have tables like reviews and summaries and compute HuggingFaceSentiment(review) and HuggingFaceSentiment(summary). Even though the signature is fixed, it's used multiple times. |
Wow /\ didn't think about this case |
https://github.com/ddkang/aidb-new/blob/c6303c6bf6b5576f1bdc664b00d99958b9e4ca3d/aidb/utils/constants.py#L20
I think including column name in the table is not good as it exceeds the limit.
We should include service name in the cache table so that we can distinguish different cache tables.
The text was updated successfully, but these errors were encountered: