Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wasm version of Verovio instead of customized toolkit for development #1221

Closed
yinanazhou opened this issue Jun 18, 2024 · 0 comments
Closed

Use wasm version of Verovio instead of customized toolkit for development #1221

yinanazhou opened this issue Jun 18, 2024 · 0 comments

Comments

@yinanazhou
Copy link
Member

The advantage of wasm is that you can then use the official develop available here:

importScripts('https://www.verovio.org/javascript/develop/verovio-toolkit-wasm.js');

For two reasons:

  1. it is more modern
  2. the latest develop is always available with CI
@yinanazhou yinanazhou changed the title Use wasm version of Verovio instead of customized toolkit Use wasm version of Verovio instead of customized toolkit for development Jun 19, 2024
yinanazhou added a commit that referenced this issue Jun 19, 2024
@yinanazhou
build!: remove external and use wasm verovio
ba92337 
- remove customized external verovio module (setup-verovio, verovio-util/)
- update webpack config, yarn.lock, package.json
- use `wasm` verovio toolkit
- introduce verovio worker for development

Resolves: #1221
yinanazhou added a commit that referenced this issue Jun 25, 2024
@yinanazhou
build!: separate verovio for prod and dev
d418622 
- Use `wasm` verovio for development (`webpack.config.js`)
- Load from verovio website for production (`webpack.pages-config.js`)
- Remove redundant `webpack.dev.config.js`

Resolves: #1219, #1221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yinanazhou