Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neume information #23

Closed
zoemcl opened this issue May 16, 2018 · 5 comments
Closed

Neume information #23

zoemcl opened this issue May 16, 2018 · 5 comments

Comments

@zoemcl
Copy link
Collaborator

zoemcl commented May 16, 2018

provide neume information (system position, pitch, etc.) when clicked on.

@zoemcl zoemcl added this to the Neon2 - Rendering milestone May 16, 2018
@zoemcl zoemcl self-assigned this May 16, 2018
@ATranimal ATranimal assigned ATranimal and unassigned zoemcl May 17, 2018
@ATranimal
Copy link
Collaborator

50fca0e

Preliminary work completed, information box now pops up and displays pitch information for neumes + custos.

TODO:
-Refactor into its own js file
-Somehow get clef information (ID is missing since its not a separate XML element)
-Get grouping name from verovio (hard? since its a map)

@JRegimbal
Copy link
Collaborator

c9964d2

By here everything is in its own file and we can get information for neumes, clefs, and custos.
We have two general functions added to vrv::Toolkit. Clef information is gotten through the staffDef tag in a bit of a roundabout way, but it doesn't seem there's a more straightforward way.

Neume grouping names are in a map local to InfoController.js as to not add a neon-specific function to verovio.

@zoemcl can you think of anything left to do for this issue?

@JRegimbal JRegimbal self-assigned this May 29, 2018
@zoemcl
Copy link
Collaborator Author

zoemcl commented May 29, 2018

Only thing left to do would be to display the retrieved information in a nice and consistent way but that is purely a cosmetic issue.

@JRegimbal
Copy link
Collaborator

Tried to make it look more like the info box in Neon.js in 0ead422.

@zoemcl
Copy link
Collaborator Author

zoemcl commented May 29, 2018

Looks good!

@zoemcl zoemcl closed this as completed May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants