New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure notification object exists #7326

Merged

Robyt3 merged 1 commit into ddnet:master from def-:pr-notif

Oct 8, 2023

Member

def- commented Oct 8, 2023

Seen in https://forum.ddnet.org/viewtopic.php?p=71604

Checklist

Tested the change ingame
Provided screenshots if it is a visual change
Tested in combination with possibly related configuration options
Written a unit test (especially base/) or added coverage to integration test
Considered possible null pointers and out of bounds array indexing
Changed no physics that affect existing maps
Tested the change with ASan+UBSan or valgrind's memcheck (optional)


          Make sure notification object exists

1f5a764

Robyt3 approved these changes

View reviewed changes

Robyt3 added this pull request to the merge queue

Merged via the queue into ddnet:master with commit 34b91fc

14 checks passed

def- deleted the pr-notif branch

October 8, 2023 20:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet