Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untested methods #13

Closed
bquorning opened this issue May 25, 2018 · 5 comments
Closed

Untested methods #13

bquorning opened this issue May 25, 2018 · 5 comments

Comments

@bquorning
Copy link
Contributor

It would be nice to have a more comprehensive test suite. The following methods aren’t covered by the current tests:

  • Pagy::Frontend#pagy_nav
  • Pagy::Frontend#pagy_url_for
  • Pagy::Frontend#pagy_link_proc
  • Pagy::Backend#pagy
  • Pagy::Backend#pagy_get_vars
  • Pagy::Backend#pagy_get_items
@ddnexus
Copy link
Owner

ddnexus commented May 25, 2018

Yeah, it would be nice... and it would be even better having a PR contributed by some good soul... ;)

@gamafranco
Copy link
Contributor

So, we're done to just this issue? 👏 👏 👏

@ddnexus
Copy link
Owner

ddnexus commented May 30, 2018

Thanks to the great guys who contributed with PRs and with reporting issues and feature requests, we just got out the v0.8.0 which has a few more useful features, it is a bit faster and uses even a bit less memory!

I've just run the benchmarks and I was not expecting that even after adding new stuff the performance got improved!

@ddnexus
Copy link
Owner

ddnexus commented Jun 1, 2018

Pagy::Frontend methods are all tested. Missing Pagy::Backend methods.

@gamafranco
Copy link
Contributor

🎉 🎉 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants