-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Untested methods #13
Comments
Yeah, it would be nice... and it would be even better having a PR contributed by some good soul... ;) |
So, we're done to just this issue? 👏 👏 👏 |
Thanks to the great guys who contributed with PRs and with reporting issues and feature requests, we just got out the v0.8.0 which has a few more useful features, it is a bit faster and uses even a bit less memory! I've just run the benchmarks and I was not expecting that even after adding new stuff the performance got improved! |
Pagy::Frontend methods are all tested. Missing Pagy::Backend methods. |
🎉 🎉 🎉 🎉 🎉 |
It would be nice to have a more comprehensive test suite. The following methods aren’t covered by the current tests:
Pagy::Frontend#pagy_nav
Pagy::Frontend#pagy_url_for
Pagy::Frontend#pagy_link_proc
Pagy::Backend#pagy
Pagy::Backend#pagy_get_vars
Pagy::Backend#pagy_get_items
The text was updated successfully, but these errors were encountered: