Allowing users to override the request path - V6 #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toring and testing of the calendars files
- Used pnpm instead of npm - Updated cypress to 10
* Add Dependabot for GitHub Actions * Exclude Style/RedundantInitialize cop to get specs green
Bumps [actions/github-script](https://github.com/actions/github-script) from 3 to 6. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v3...v6) --- updated-dependencies: - dependency-name: actions/github-script dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Bump actions/cache from 2 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v2...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Bump codecov/codecov-action from 1.3.2 to 3.1.0 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 1.3.2 to 3.1.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v1.3.2...v3.1.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Bump falti/dotenv-action from 0.2.7 to 0.2.8 Bumps [falti/dotenv-action](https://github.com/falti/dotenv-action) from 0.2.7 to 0.2.8. - [Release notes](https://github.com/falti/dotenv-action/releases) - [Commits](falti/dotenv-action@v0.2.7...v0.2.8) --- updated-dependencies: - dependency-name: falti/dotenv-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
@ddnexus Do you want me to squash these commits? |
|
@elliotlarson Thank you for your fast action and sorry for the lack of feedback on my side. I am in a loooong month and quite overwhelmed by too many new things... The PR passed the tests, so it is formally OK, however I need a few more days to find some time for it. |
|
@ddnexus Oh, no worries. Sounds good 👍 |
|
@elliotlarson I refactored the v6 branch and it results in a big mess with this PR. If you could create a new PR, adding your commits on top of v6, (or shash them there if you prefer) everything should be cleaner. Thank you. |
|
@ddnexus Okay, cool. I'll work on that. |
While at it, I didn't find the entry of the new variable in the pagy.rb initializer. Please, could you check that? |
ddnexus
pushed a commit
that referenced
this pull request
Dec 16, 2022
|
@elliotlarson Thank you. I had a bit of time and I edited it. (6e939a0) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #403 code on top of the V6 branch