Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dependabot for GitHub Actions #392

Merged
merged 2 commits into from
Jun 25, 2022
Merged

Add Dependabot for GitHub Actions #392

merged 2 commits into from
Jun 25, 2022

Conversation

petergoldstein
Copy link
Contributor

As the checkout action in the configuration is out of date, Dependabot should open a PR to update the action after this is merged.

Style/RedundantInitialize:
Exclude:
- test/mock_helpers/arel.rb

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the bug in rubocop that complains for the "redundant initializer" and also complains for the Unnecessary disabling of Style/RedundantInitialize if you disable it with inlining # rubocop:disable Style/RedundantInitialize 🤷

In the v6 branch I added a dummy line in order to avoid the global exclude of a single file, wondering which one is "better"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddnexus Just let me know how you'd prefer to handle it and I can make any change necessary. I don't have a strong preference here.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go with yours.

Please, could you revert my dummy line, and add some comment like # cannot inline the disabling in the file because rubocop complains anyway comment on top of the exclude in .rubocop.yml. Thank you.

(I tried to do it myself rebasing your branch on v6 but when I tried to push it to your branch, there was a long list of commits added below yours, and I didn't wanted to mess up your branch. Github Squash and merge will sort it out.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddnexus I've made these changes. Please let me know if anything else is required. Thanks.

@benkoshy
Copy link
Collaborator

benkoshy commented Jun 22, 2022

What does it do?

It checks whether any the github actions in the .workflow directory are out of date. If they are, it creates a PR for the latest version.

This PR looks good, checks out (pun intended), and complies with what Github recommends (see reference documentation here).

Re the Rubocop commit - not sure whether the maintainer would prefer the master or v6 branch?

- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... I actually completely disabled dependabot because it complains for too many things that are not important for the gem itself. Just too annoying to keep up with it 🙃

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed (thanks @benkoshy) that is checking the github-actions, which is actually very useful!

@ddnexus ddnexus changed the base branch from master to v6 June 22, 2022 23:23
@ddnexus ddnexus merged commit 6fb7e1d into ddnexus:v6 Jun 25, 2022
@ddnexus
Copy link
Owner

ddnexus commented Jun 25, 2022

Thank you @petergoldstein

ddnexus pushed a commit that referenced this pull request Dec 13, 2022
benkoshy pushed a commit to benkoshy/pagy that referenced this pull request Dec 15, 2022
* Add Dependabot for GitHub Actions
* Exclude Style/RedundantInitialize cop to get specs green
benkoshy pushed a commit to benkoshy/pagy that referenced this pull request Dec 15, 2022
* Add Dependabot for GitHub Actions
* Exclude Style/RedundantInitialize cop to get specs green
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants