Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs additions #419

Closed
ddnexus opened this issue Dec 16, 2022 · 7 comments
Closed

Docs additions #419

ddnexus opened this issue Dec 16, 2022 · 7 comments
Assignees

Comments

@ddnexus
Copy link
Owner

ddnexus commented Dec 16, 2022

Integrate with retype the docs addition made by #404 #411, #417.

@benkoshy

This comment was marked as resolved.

@benkoshy

This comment was marked as resolved.

@ddnexus
Copy link
Owner Author

ddnexus commented Dec 19, 2022

The commit adds test for nav_js, not combo_nav_js as mentioned in the description (which indeed is not supported by countless).

I overlooked the description and focused only on the commit. We have to sort this out.

Maybe @hvanhonacker can clarify that.

@ddnexus
Copy link
Owner Author

ddnexus commented Dec 20, 2022

OK, I got a minute and it looks like there's just a typo in the description of #411.

Now I remember looking at the #410 and reproducing the error... indeed this is a fix for *nav_js and the *combo_nav_js has nothing to do with it.

@benkoshy So back to the doc to change: there is no docs affected. My bad indicating this PR. Please, skip #411.

Thanks

@benkoshy
Copy link
Collaborator

chrs - that leaves only #417 remaining.

@ddnexus
Copy link
Owner Author

ddnexus commented Dec 20, 2022

"chrs"??? 🤔

@ddnexus
Copy link
Owner Author

ddnexus commented Dec 21, 2022

#417 b5f64f5

@ddnexus ddnexus closed this as completed Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants