Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebrew doesn't show correct version number #38

Closed
jdx opened this issue Sep 18, 2014 · 7 comments
Closed

homebrew doesn't show correct version number #38

jdx opened this issue Sep 18, 2014 · 7 comments

Comments

@jdx
Copy link
Contributor

jdx commented Sep 18, 2014

this was a known issue when doing the forego stuff, we don't get the version number in forego version. Any ideas on a quick way to resolve this?

screen shot 2014-09-18 at 9 20 17 am

@ddollar
Copy link
Owner

ddollar commented Sep 18, 2014

I just put some new commits on master and will tag 0.13.0. You can now use a buidl command like this

godep go build -o forego -ldflags "-X main.Version 0.13.0 -X main.allowUpdate false"

@ddollar ddollar closed this as completed Sep 18, 2014
@ddollar
Copy link
Owner

ddollar commented Sep 18, 2014

Made another tweak, 0.13.1

@jdx
Copy link
Contributor Author

jdx commented Sep 18, 2014

to be clear, you think this is the line we should update with that? https://github.com/Homebrew/homebrew/blob/master/Library/Formula/forego.rb#L39

@jdx
Copy link
Contributor Author

jdx commented Sep 18, 2014

or do you think we could move this into the Makefile?

@ddollar
Copy link
Owner

ddollar commented Sep 18, 2014

Perhaps we could move the version bit to the Makefile like this:

make VERSION=0.13.0

I'm not sure how to handle the allowUpdates bit but that will be very specific to homebrew.

@jdx
Copy link
Contributor Author

jdx commented Sep 18, 2014

you mean, in terms of not showing that command?

@ddollar
Copy link
Owner

ddollar commented Sep 18, 2014

AFAIK binaries in homebrew are not supposed to update themselves outside of the homebrew channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants