Crashing randomly (nim 1.6.14)

[nbaertsch]

Sometimes getting a RangeDefect exception raised in progress= with stack trace:

C:\Users\ABC123\.nimble\pkgs\suru-0.3.1\suru.nim(131) inc
C:\Users\ABC123\.nimble\pkgs\suru-0.3.1\suru.nim(73) inc
C:\Users\ABC123\.nimble\pkgs\suru-0.3.1\suru.nim(54) progress=
C:\Users\ABC123\.choosenim\toolchains\nim-1.6.14\lib\system\fatal.nim(54) sysFatal
Error: unhandled exception: value out of range: 3551325900 notin -2147483648 .. 2147483647 [RangeDefect]

I'm not overly familiar with this codebase so I will not suggest any change but this should be an easy fix (maybe?) if I understand the issue right.

[nbaertsch]

line 54: ssb.timeStat.push (newTime.ticks - ssb.lastChange.ticks).int

assigning an int64 to a float64 is the cause and I think it maybe could be fixed just simply by
ssb.timeStat.push (newTime.ticks - ssb.lastChange.ticks).float

[de-odex]

I am not too sure. line 34

proc push(mv: var ExpMovingAverager, value: SomeNumber) =
  let value = value.float

should catch that as well.

[nbaertsch]

still running into this issue, now on nim 2.0.0. Is it perhaps to do with using the same name for push(... , value: SomeNumber) and let value = value.float? I am not sure nim handles this name conflict. Confirmed that my change above fixes the issue but a preferred fix would be in the push function`.