Add md5 comparison tool #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- partial fix for deadsy#28 - add README for interpreting md5 results - add MD5SUM reference files to all example directories - add md5tool executable to gitignore - simplify top-level Makefile Co-authored-by: Steve Traugott <stevegt@t7a.org> Co-authored-by: ryan <xfactor529@gmail.com>
add md5 comparison tool to test suite
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jason,
Here's the commit for the md5 comparison tool, including a README for operation. We debated some of the design decisions amongst ourselves; some of this could be done differently, but in general this is at least a reasonable stopgap until we have real unit tests, so I'm pretty happy.
At the moment, we're automatically running the md5 checks as part of
make test, which seems to be lightweight enough. We thought about splitting it out as e.g.make md5sums, which might make sense if we find it getting in the way during fast iterations. Otherwise it's a fast recovery when a rendered file does need to change -- just runmake update-md5sumsin the example's own directory. Details are in the README.As far as change frequency, so far the only rendered file that has a new md5 sum since 05 Nov 2020 is flange.stl -- the shrink variable changing from a var to a const was a factor in causing some floating point rounding differences there. We learned a lot while doing a deep dive on that one. ;-) The moves of things from sdf/ to obj/ so far haven't altered any of the rendered outputs.