Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write typespecs #5

Closed
deadtrickster opened this issue Jul 24, 2016 · 9 comments
Closed

Write typespecs #5

deadtrickster opened this issue Jul 24, 2016 · 9 comments
Milestone

Comments

@deadtrickster
Copy link
Owner

deadtrickster commented Jul 24, 2016

Maybe play with TypEr?

@deadtrickster deadtrickster added this to the Version 2.0 milestone Jul 24, 2016
@yurrriq
Copy link
Contributor

yurrriq commented Aug 14, 2016

I'm working on this a bit now. There are many typos, e.g. atom should be atom().

@deadtrickster
Copy link
Owner Author

So how can you describe present typespecs state after merging your PR?

@yurrriq yurrriq mentioned this issue Aug 14, 2016
10 tasks
@yurrriq
Copy link
Contributor

yurrriq commented Aug 14, 2016

In general, what's there is solid, except for what's mentioned in #12. I'd like to see at least all exported functions covered with type specs.

@deadtrickster
Copy link
Owner Author

I commited few specialized types like registry(), collector(), buckets(), looks good to me. Let me know what you think.

@yurrriq
Copy link
Contributor

yurrriq commented Aug 14, 2016

LGTM. I do like when (see comments) for uniformity, if nothing else.

@deadtrickster
Copy link
Owner Author

can you please give an example?

@yurrriq
Copy link
Contributor

yurrriq commented Aug 14, 2016

This example has other issues, but shows what I mean wrt when.

@deadtrickster
Copy link
Owner Author

so looks like this task is finished as well as #12. What you think?

@yurrriq
Copy link
Contributor

yurrriq commented Aug 15, 2016

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants