Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__SIGNATURE_MAX_LENGTH already defined when using multiple PDFDoc objects in the same script. #74

Closed
Jacq opened this issue Jul 18, 2024 · 2 comments · Fixed by #75
Closed

Comments

@Jacq
Copy link

Jacq commented Jul 18, 2024

Defining constant __SIGNATURE_MAX_LENGTH in PDFDoc.php:

define('__SIGNATURE_MAX_LENGTH', $len);

, causes a error constant already defined when using the library to sign multiple times a document. The constant is created during the first sign. I suppose that this __SIGNATURE_MAX_LENGTH depends of signature_data parameters so should be move to a protected parameter instead of a global constant?

Thanks!

Jacq

@dealfonso
Copy link
Owner

yes, I think it is a good idea. Are you willing to contribute to sapp?

@Jacq
Copy link
Author

Jacq commented Jul 22, 2024

It looks that @erikn69 has done it already, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants