Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unification of true|false and ON|OFF #174

Closed
ghost opened this issue May 19, 2021 · 6 comments
Closed

Unification of true|false and ON|OFF #174

ghost opened this issue May 19, 2021 · 6 comments

Comments

@ghost
Copy link

ghost commented May 19, 2021

Maybe it would be nice to have a uniform line for the true/false, ON/OFF option? Currently both versions are present, e.g., NATIVE_OPTIMIZATIONS=true|false and MKL=ON|OFF.
@koecher
Copy link
Contributor

koecher commented May 20, 2021

I find this a very useful proposal. The true/false option should be preferred.

@ghost
Copy link
Author

ghost commented May 20, 2021

Honestly, I would have preferred the ON/OFF option, as it would fit to the cmake option style. @koecher What was your intention?

@tjhei
Copy link
Member

tjhei commented May 20, 2021

I agree that this should be unified. I don't feel strongly about it but I would use ON/OFF as well.

@koecher
Copy link
Contributor

koecher commented May 20, 2021

okay, then let’s go for ON/OFF

@ghost
Copy link
Author

ghost commented May 21, 2021 •
edited by ghost
Loading

Fine, I will prepare a pr in the next few days. See #176.

@ghost ghost mentioned this issue May 25, 2021
Merged
@ghost
Copy link
Author

ghost commented May 27, 2021

Closed, as #176 is merged.

@ghost ghost closed this as completed May 27, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tjhei @koecher