Cmake error when compiling Trilinos on Ubuntu 18.04 through Candi

[blaisb]

Dear all,
When trying to compile Trilinos on Ubuntu 18.04 through Candi master branch I get the following error:
CMake Error: Unknown argument -O5 CMake Error: Run 'cmake --help' for all supported options. Failure with exit status: 1 Exit message: There was a problem configuring trilinos 12-18-1

The CMake version on my machine is 3.20.3 (installed through snap)
And my compiler is gcc 7.5
I can compile Trilinos manually using CMake elsewhere and I used to be able to do it through candi. Was this flag recently introduced?

The following SO post seems to mention that this means this flag was always ignored?
https://stackoverflow.com/questions/67390153/cmake-error-unknown-argument-vv-when-installing-trilinos

[koecher]

@blaisb can you try it with the candi package cmake? This was recently updated to 3.16 from 3.11 and I read that there are issues with cmake 3.20.

[koecher]

@tjhei I believe that the -O5 setting in the trilinos package for the fortran compiler should be corrected.

[blaisb]

@blaisb can you try it with the candi package cmake? This was recently updated to 3.16 from 3.11 and I read that there are issues with cmake 3.20.

Is there a way to force candi to use the bundled CMAKE? Otherwise I can uninstall cmake on my machine and reinstall it if you want.

[koecher]

candi sets automaticly the path correctly during its run, you only have to use it before the trilinos package

[koecher]

@blaisb enable line 54 in the candi.cfg file

[blaisb]

@blaisb enable line 54 in the candi.cfg file

This works (at least for Trilinos)
It would be worth it though to start preparing for cmake 3.20 :). I can help with that if you want.
Thanks for the help!

[koecher]

@blaisb nice. I think I had the same issue two weeks ago and the fix was changing O5 to O3, but I forget the PR and the details. Would be cool if you can test this.

[blaisb]

@blaisb nice. I think I had the same issue two weeks ago and the fix was changing O5 to O3, but I forget the PR and the details. Would be cool if you can test this.

Yeah sure, i'll try to dig into it and propose a PR that changes the Trilinos flag. My students use candi a lot to build since they are generally less familiar with CMake, so I'd be glad to help in maintaining it :).

[tjhei]

We are talking about

candi/deal.II-toolchain/packages/trilinos.package

Line 147 in 76244c0

-D CMAKE_FORTRAN_FLAGS:STRING=-g -O5 \

right? It looks like there are quotes around these options missing as well or am I totally confused?

[koecher]

@tjhei yes this line. For me, setting O5 to O3 was working, at least I don't know O5; cf.

https://gcc.gnu.org/onlinedocs/gcc-8.2.0/gcc/Optimize-Options.html

[blaisb]

@tjhei yes this line. For me, setting O5 to O3 was working, at least I don't know O5; cf.

https://gcc.gnu.org/onlinedocs/gcc-8.2.0/gcc/Optimize-Options.html

Yeah so I don't think that O5 is recognized as an option for the Fortran flag. In the past (CMAKE <3.20) this is means it was just ignored, but now if the flag is not accepted by the compiler, CMake aborts. Hence it just means that this flag was most likely never really used for most platforms/compilers. Would be a good idea to switch to O3.

[tjhei]

Yeah, makes sense.

[ghost]

We replaced the compiler flag O5 to O3 in #192.