New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up precice-ci.yml #93
Conversation
I don't know anything about how these CI files should be written. This requires someone else's approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice when you get the docker image in the github-actions script.
@peterrum What's the status here? |
I've solved the merge conflict by rebasing. @peterrum -- I hijacked your PR 🏴☠️ The I will also apply my suggestions in a separate commit. Updating to the latest preCICE 2.5.0 release yields a different output and thus lets the test fail. I will thus update to preCISE 2.4.0 instead. We can consider an update to 2.5.0 in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcfehling Thanks for the follow-up commits! Looks good to me. I cannot approve my own PR^^
The PR has been around for a year. Let's merge this. |
FYI @davidscn