Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the code gallery programs compile and run. #15073

Open
bangerth opened this issue Apr 10, 2023 · 6 comments
Open

Check that the code gallery programs compile and run. #15073

bangerth opened this issue Apr 10, 2023 · 6 comments
Milestone

Comments

@bangerth
Copy link
Member

Do this for every release, just before we make the release, then move the release milestone to the following release.

@bangerth bangerth added this to the Release 9.5 milestone Apr 10, 2023
@bangerth bangerth changed the title Check that the code gallery programs compile and run... Check that the code gallery programs compile and run. Apr 10, 2023
@marcfehling
Copy link
Member

marcfehling commented Apr 10, 2023

We can also set up the CI to do it, similar to the preCICE one we have running now.

For this we can use the deal.II docker images, and set up a cronjob that executes the workflow, let's say, every sunday.

We basically already have a working gihub-actions script in dealii/code-gallery#93. We need to enhance it to span all tutorial programs.

EDIT: We can set up the scheduled jobs that they create issues automatically upon failure. That is a really neat feature :)

@bangerth
Copy link
Member Author

I'd be in favor of this, though in the end it still boils down to someone having to look at the results and, if necessary, do something about it.

@tamiko
Copy link
Member

tamiko commented Apr 11, 2023

We can also make compiling the code gallery part of the regression testsuite. This would require no infrastructure changes.

@marcfehling
Copy link
Member

dealii/code-gallery#133 will also help setting up CI and regression testers.

@bangerth
Copy link
Member Author

I can compile the current set of programs, and could run them a month or so ago. Bumping to the next release.

@bangerth bangerth modified the milestones: Release 9.5, Release 9.6 Jun 16, 2023
@tamiko tamiko removed the Meta label Jul 4, 2023
@bangerth
Copy link
Member Author

bangerth commented May 9, 2024

We aren't done with this, but there are now 16 of these tests already in tests/examples, with #16988 and #16989 currently pending. This is decent progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants