Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Wolfgang Bangerth <bangerth@colostate.edu>
  • Loading branch information
luca-heltai and bangerth committed Aug 6, 2023
1 parent fda43db commit 6494df2
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions include/deal.II/fe/fe_values_coupling.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ namespace FEValuesViews
* A class that provides a renumbered view to a given FEValuesViews object.
*
* In general, the order of the degrees of freedom and quadrature points
* follows the one of the FEValues object. However, in some cases, it is
* follows the one of the FEValues object, which itself uses the numbering provided by
* the FiniteElement and Quadrature objects it uses. However, in some cases, it is
* convenient to group together degrees of freedom and quadrature points in a
* different order. This class provides a view to a given FEValuesViews
* object, where the degrees of freedom and quadrature points are renumbered
Expand Down Expand Up @@ -83,10 +84,10 @@ namespace FEValuesViews
* quadrature points. An empty renumbering vector simply means that no
* renumbering is performed.
*
* @note The renumbering vectors may *not* match the dimensions of the
* @note The renumbering vectors are *not* required to match the dimensions of the
* underlying view, i.e., you could use this class to only run over half of
* the degrees of freedom, and integrating only over half of the current
* cell, if you wish to do so. The important part is that every entry of
* cell by selecting a subset of quadrature points, if you wish to do so. The important part is that every entry of
* each renumbering vector is a legal value for the underlying view object.
* We allow the dof renumbering vector to contain
* `numbers::invalid_unsigned_int` values, which are ignored, and produce
Expand Down Expand Up @@ -118,7 +119,7 @@ namespace FEValuesViews
*
* @dealiiRequiresUpdateFlags{update_values}
*/
typename ViewType::value_type
value_type
value(const unsigned int shape_function, const unsigned int q_point) const;

/**
Expand Down

0 comments on commit 6494df2

Please sign in to comment.