Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUNDIALS: replace copy with N_Vector module #11380

Closed
sebproell opened this issue Dec 16, 2020 · 2 comments
Closed

SUNDIALS: replace copy with N_Vector module #11380

sebproell opened this issue Dec 16, 2020 · 2 comments

Comments

@sebproell
Copy link
Contributor

With #11278 new SUNDIALS versions will be supported. After this is merged the copy operations between dealii and SUNDIALS vectors should be replaced by "teaching" dealii's vector operations to SUNDIALS.

I already described the N_Vector module briefly here: #11278 (comment) and the documentation can be found here: https://computing.llnl.gov/sites/default/files/public/ark_guide-4.5.0_0.pdf starting on page 307.

A very simple first implementation with some tests can be found here: https://github.com/sebproell/dealii/pull/1/files. I will improve a little on this work and open a draft PR soon.

@peterrum
Copy link
Member

Is this issue resolved?

@sebproell
Copy link
Contributor Author

Nope, I want to at least replace the copy functions in the ARKode integrator. PR almost ready, I just need some backwards-compatibility adaptations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants