Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUNDIALS: Use new N_Vector module in ARKode wrapper #11655

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

sebproell
Copy link
Contributor

Follow-up to #11654 and part of #11380

Finally, this PR removes the old copy calls from the ARKode module and replaces them with the new N_Vector functionalities from #11395.

@luca-heltai

@peterrum
Copy link
Member

/rebuild

@sebproell
Copy link
Contributor Author

Oh... Looks like I need to add the PETSc Vectors to the N_Vector instantiation now. Will open a separate PR when its done.

@peterrum
Copy link
Member

Oh... Looks like I need to add the PETSc Vectors to the N_Vector instantiation now. Will open a separate PR when its done.

Sounds good. We will merge that one quickly.

@luca-heltai
Copy link
Member

Can you rebase, to check that everything is in place?

@sebproell
Copy link
Contributor Author

Should I add an entry to the changelog for the collected changes to N_Vector? There is actually some new functionality I didn't explictly mention: ARKode should now support all vector types, including Trilinos and L:d:V., because the new N_Vector implementation supports it.

@peterrum
Copy link
Member

Should I add an entry to the changelog for the collected changes to N_Vector?

Yup.

@sebproell
Copy link
Contributor Author

There is actually some new functionality I didn't explictly mention: ARKode should now support all vector types, including Trilinos and L:d:V., because the new N_Vector implementation supports it.

Actually, I will wait with the changelog entry since ARKode isn't yet compiled with those vector types. Will follow up.

@luca-heltai luca-heltai merged commit 1e19980 into dealii:master Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants