Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify declaration of DataOutStack #12327

Closed
bangerth opened this issue May 27, 2021 · 5 comments · Fixed by #13808
Closed

Simplify declaration of DataOutStack #12327

bangerth opened this issue May 27, 2021 · 5 comments · Fixed by #13808

Comments

@bangerth
Copy link
Member

#12322 made me look up the DataOutStack class, which has this beautiful declaration:

/**
 * @deprecated Use DataOutStack<dim, spacedim> instead.
 */
template <int dim, int spacedim = dim, typename DoFHandlerType = void>
class DataOutStack;


template <int dim, int spacedim, typename DoFHandlerType>
class DataOutStack : public DataOutStack<dim, spacedim, void>
{
public:
  DEAL_II_DEPRECATED
  DataOutStack()
    : DataOutStack<dim, spacedim, void>()
  {}
};


template <int dim, int spacedim>
class DataOutStack<dim, spacedim, void> : public DataOutInterface<dim + 1>
{
  ...

It is certainly innovative to derive X<T> from X<void> -- but also confusing :-)

I think we can remove this now.

@bangerth bangerth added this to the Release 10.0 milestone May 27, 2021
@marcfehling
Copy link
Member

We should agree on a point up to which we want to be backwards compatible to the old hp::DoFHandler formalism and the DoFHandlerType templates. Release 10.0 might be a bit early -- but I have no strong opinion on that.

@bangerth
Copy link
Member Author

The old declaration was already deprecated, so I think it's fair to remove it.

@marcfehling
Copy link
Member

We just deprecated the Legacy:: namespace with the transition classes in that regard.

I would prefer if we remove anything related to DoFHandlerType at once (Legacy classes and others). So maybe wait until Release 10.1...?

@bangerth
Copy link
Member Author

OK.

@marcfehling
Copy link
Member

Related to #10333.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Cleanup hp::DoFHandler
Remove hp::DoFHandler after 9.4
Development

Successfully merging a pull request may close this issue.

2 participants