Introduce patch_dim and patch_spacedim in DataOut classes.
#12322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcfehling
force-pushed
the
patch-spacedim
branch
from
a39435a
to
f5e84e5
Compare
bangerth
approved these changes
May 27, 2021
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11221. Part of #10333.
Reading through the implementation of the DataOut classes in #11221 left me confused about which of the
dimtemplate parameters belonged to the dof_handler and which to the actual patch.This is an attempt to make the interface more descriptive by introducing
patch_dimandpatch_spacedimstatic variables for classesDataOutFacesDataOutRotatationDataOutStackI believe that I found some copy&paste errors along the way.
We could also use these new parameters to overhaul the actual implementation (e.g. by replacing some
Point<dim>byPoint<patch_spacedim>). However, to do this properly, we would need actual tests fordim != spacedim, which we don't have currently. Let's leave this as a future task.@bangerth -- FYI