You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#12411 renamed FEInterfaceValues::jump() into FEInterfaceValues::jump_in_shape_values() and similarly for related functions. But I find these names awkward since they have a plural values when they really only return a single value: the jump in the value of a single shape function. We also only have FEValues::shape_value() and FEValues::shape_gradient(), for example.
We should rename these functions a second time, I believe, and remove the plural.
The text was updated successfully, but these errors were encountered:
Ah, I see. One could read it that way. jump_in_values() still sounds plural-y to me because I would write that as "the jump in the value of the function at a point x" -- the function does not have multiple values at a point. But I agree that one could interpret it the way you say.
Related to #8884. @jppelteret: FYI
#12411 renamed
FEInterfaceValues::jump()
intoFEInterfaceValues::jump_in_shape_values()
and similarly for related functions. But I find these names awkward since they have a plural values when they really only return a single value: the jump in the value of a single shape function. We also only haveFEValues::shape_value()
andFEValues::shape_gradient()
, for example.We should rename these functions a second time, I believe, and remove the plural.
The text was updated successfully, but these errors were encountered: