New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the meaning of jump_in/average_of_* in FEInterfaceValues. #13197
Conversation
* | ||
* @note The name of the function is supposed to be read as "the jump | ||
* (singular) of the values (plural: one or two possible values) of | ||
* the shape function (singular)". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the values (plural) of the shape function (singular)
This may be a stupid question, but is this true for both continuous and discontinuous elements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, for continuous elements, the two values happen to be the same, and so the jump is zero.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And there's one shape function, right? But aren't there two shape functions (two DoFs) when you have discontinuous FEs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still one shape function, but in the case of discontinuous elements, it is nonzero in the interior of one cell and zero on all other cells. So it's one shape function (that one indicated by the arguments) that has two values at the interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least that's what this operation does: take the jump of one shape function. For DGQ, there happen to be two (or more, in the case of a vertex) shape functions that are defined at the same node locations. But we're only looking at one of them at any given time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, right. Thanks for taking the time to clarify that. As I said, stupid question :-D
@@ -227,6 +235,10 @@ namespace FEInterfaceViews | |||
* - \nabla u_{\text{cell1}}$ on the interface for the shape function @p | |||
* interface_dof_index at the quadrature point @p q_point of | |||
* the component selected by this view. | |||
* | |||
* @note The name of the function is supposed to be read as "the jump | |||
* (singular) of the Hessians (plural: one or two possible values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* (singular) of the Hessians (plural: one or two possible values | |
* (singular) in the Hessians (plural: one or two possible values |
* $\jump{u}=u_{\text{cell0}}$, that is "the value here (minus zero)". | ||
* | ||
* @note The name of the function is supposed to be read as "the jump | ||
* (singular) of the values (plural: one or two possible values) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* (singular) of the values (plural: one or two possible values) | |
* (singular) in the values (plural: one or two possible values) |
@@ -1739,6 +1803,10 @@ class FEInterfaceValues | |||
* | |||
* If this is a boundary face (at_boundary() returns true), then | |||
* $\jump{\nabla^2 u} = \nabla^2 u_{\text{cell0}}$. | |||
* | |||
* @note The name of the function is supposed to be read as "the jump | |||
* (singular) of the Hessians (plural: one or two possible values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* (singular) of the Hessians (plural: one or two possible values | |
* (singular) in the Hessians (plural: one or two possible values |
So fixed. Thanks for the comments! |
Fixes #13103.
/rebuild