Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the meaning of jump_in/average_of_* in FEInterfaceValues. #13197

Merged
merged 1 commit into from Jan 9, 2022

Conversation

bangerth
Copy link
Member

@bangerth bangerth commented Jan 8, 2022

Fixes #13103.

/rebuild

*
* @note The name of the function is supposed to be read as "the jump
* (singular) of the values (plural: one or two possible values) of
* the shape function (singular)".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the values (plural) of the shape function (singular)

This may be a stupid question, but is this true for both continuous and discontinuous elements?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, for continuous elements, the two values happen to be the same, and so the jump is zero.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And there's one shape function, right? But aren't there two shape functions (two DoFs) when you have discontinuous FEs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still one shape function, but in the case of discontinuous elements, it is nonzero in the interior of one cell and zero on all other cells. So it's one shape function (that one indicated by the arguments) that has two values at the interface.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least that's what this operation does: take the jump of one shape function. For DGQ, there happen to be two (or more, in the case of a vertex) shape functions that are defined at the same node locations. But we're only looking at one of them at any given time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right. Thanks for taking the time to clarify that. As I said, stupid question :-D

include/deal.II/fe/fe_interface_values.h Outdated Show resolved Hide resolved
include/deal.II/fe/fe_interface_values.h Outdated Show resolved Hide resolved
include/deal.II/fe/fe_interface_values.h Outdated Show resolved Hide resolved
@@ -227,6 +235,10 @@ namespace FEInterfaceViews
* - \nabla u_{\text{cell1}}$ on the interface for the shape function @p
* interface_dof_index at the quadrature point @p q_point of
* the component selected by this view.
*
* @note The name of the function is supposed to be read as "the jump
* (singular) of the Hessians (plural: one or two possible values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* (singular) of the Hessians (plural: one or two possible values
* (singular) in the Hessians (plural: one or two possible values

include/deal.II/fe/fe_interface_values.h Outdated Show resolved Hide resolved
include/deal.II/fe/fe_interface_values.h Outdated Show resolved Hide resolved
* $\jump{u}=u_{\text{cell0}}$, that is "the value here (minus zero)".
*
* @note The name of the function is supposed to be read as "the jump
* (singular) of the values (plural: one or two possible values)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* (singular) of the values (plural: one or two possible values)
* (singular) in the values (plural: one or two possible values)

include/deal.II/fe/fe_interface_values.h Outdated Show resolved Hide resolved
@@ -1739,6 +1803,10 @@ class FEInterfaceValues
*
* If this is a boundary face (at_boundary() returns true), then
* $\jump{\nabla^2 u} = \nabla^2 u_{\text{cell0}}$.
*
* @note The name of the function is supposed to be read as "the jump
* (singular) of the Hessians (plural: one or two possible values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* (singular) of the Hessians (plural: one or two possible values
* (singular) in the Hessians (plural: one or two possible values

include/deal.II/fe/fe_interface_values.h Outdated Show resolved Hide resolved
@bangerth
Copy link
Member Author

bangerth commented Jan 8, 2022

So fixed. Thanks for the comments!

@jppelteret jppelteret merged commit 67c40a0 into dealii:master Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Names of FEInterfaceValues functions
3 participants