Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated boost header #13640

Closed
peterrum opened this issue Apr 25, 2022 · 10 comments
Closed

Deprecated boost header #13640

peterrum opened this issue Apr 25, 2022 · 10 comments
Milestone

Comments

@peterrum
Copy link
Member

The Linux tests give the following warnings:

/home/runner/work/dealii/boost/boost/function_output_iterator.hpp:14:1: note: ‘#pragma message: This header is deprecated. Use <boost/iterator/function_output_iterator.hpp> instead.’
   14 | BOOST_HEADER_DEPRECATED("<boost/iterator/function_output_iterator.hpp>")
      | ^~~~~~~~~~~~~~~~~~~~~~~
/home/runner/work/dealii/boost/boost/range/result_iterator.hpp:20:1: note: ‘#pragma message: This header is deprecated. Use <boost/range/iterator.hpp> instead.’
   20 | BOOST_HEADER_DEPRECATED("<boost/range/iterator.hpp>")
      | ^~~~~~~~~~~~~~~~~~~~~~~
/home/runner/work/dealii/boost/boost/range/const_reverse_iterator.hpp:20:1: note: ‘#pragma message: This header is deprecated. Use <boost/range/reverse_iterator.hpp> instead.’
   20 | BOOST_HEADER_DEPRECATED("<boost/range/reverse_iterator.hpp>")
      | ^~~~~~~~~~~~~~~~~~~~~~~
/home/runner/work/dealii/boost/boost/range/reverse_result_iterator.hpp:20:1: note: ‘#pragma message: This header is deprecated. Use <boost/range/reverse_iterator.hpp> instead.’
   20 | BOOST_HEADER_DEPRECATED("<boost/range/reverse_iterator.hpp>")
      | ^~~~~~~~~~~~~~~~~~~~~~~
/home/runner/work/dealii/boost/boost/detail/no_exceptions_support.hpp:17:1: note: ‘#pragma message: This header is deprecated. Use <boost/core/no_exceptions_support.hpp> instead.’
   17 | BOOST_HEADER_DEPRECATED("<boost/core/no_exceptions_support.hpp>")
@peterrum peterrum added this to the Release 9.4 milestone Apr 25, 2022
@peterrum
Copy link
Member Author

@marcfehling These warnings also happen in our GitHub actions.

@bangerth
Copy link
Member

Do we have any indication of how we get to this place?

@bangerth
Copy link
Member

[ 89%] Building CXX object examples/CMakeFiles/step-22.release.dir/step-22/step-22.cc.o
7073
In file included from /home/runner/work/dealii/boost/boost/smart_ptr/detail/sp_thread_sleep.hpp:22,
7074
                 from /home/runner/work/dealii/boost/boost/smart_ptr/detail/yield_k.hpp:23,
7075
                 from /home/runner/work/dealii/boost/boost/smart_ptr/detail/spinlock_gcc_atomic.hpp:14,
7076
                 from /home/runner/work/dealii/boost/boost/smart_ptr/detail/spinlock.hpp:42,
7077
                 from /home/runner/work/dealii/boost/boost/smart_ptr/detail/spinlock_pool.hpp:25,
7078
                 from /home/runner/work/dealii/boost/boost/smart_ptr/shared_ptr.hpp:29,
7079
                 from /home/runner/work/dealii/boost/boost/archive/detail/helper_collection.hpp:27,
7080
                 from /home/runner/work/dealii/boost/boost/archive/detail/basic_iarchive.hpp:28,
7081
                 from /home/runner/work/dealii/boost/boost/archive/detail/common_iarchive.hpp:21,
7082
                 from /home/runner/work/dealii/boost/boost/archive/basic_binary_iarchive.hpp:30,
7083
                 from /home/runner/work/dealii/boost/boost/archive/binary_iarchive_impl.hpp:21,
7084
                 from /home/runner/work/dealii/boost/boost/archive/binary_iarchive.hpp:20,
7085
                 from /home/runner/work/dealii/dealii/include/deal.II/base/utilities.h:46,
7086
                 from /home/runner/work/dealii/dealii/examples/step-22/step-22.cc:27:
7087
/home/runner/work/dealii/boost/boost/function_output_iterator.hpp:14:1: note: ‘#pragma message: This header is deprecated. Use <boost/iterator/function_output_iterator.hpp> instead.’
7088
   14 | BOOST_HEADER_DEPRECATED("<boost/iterator/function_output_iterator.hpp>")
7089
      | ^~~~~~~~~~~~~~~~~~~~~~~

@peterrum
Copy link
Member Author

This was introduced by #13451.

@marcfehling
Copy link
Member

We don't explicitly include any of the headers that trigger the warnings anywhere in the deal.II library.

I think this is a problem that comes from inside the boost library. Bumping the bundled boost version could fix these warnings.

@marcfehling
Copy link
Member

This was introduced by #13451.

The warnings you refer to are different ones: #13451 (comment)

@luca-heltai
Copy link
Member

This maybe resolved similarly to #13927

@tamiko
Copy link
Member

tamiko commented Jun 8, 2022

The issue with this deprecated header warning is that the include chain you're seeing In file included ... is for the chain how the macro got defined and not indicative for what header is actually including the deprecated header.

@tamiko
Copy link
Member

tamiko commented Jun 8, 2022

I will now try to find what is responsible for the warning on Debian and Ubuntu.

@tamiko tamiko closed this as completed Jun 13, 2022
@tamiko
Copy link
Member

tamiko commented Jun 13, 2022

This seems to be resolved with the latest change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants