Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: add DEAL_II_CGAL_HAS_DEPRECATED_BOOST_INCLUDES check #13927

Merged
merged 2 commits into from Jun 8, 2022

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Jun 8, 2022

It is back:

In file included from /usr/include/boost/smart_ptr/detail/sp_thread_sleep.hpp:22,
                 from /usr/include/boost/smart_ptr/detail/yield_k.hpp:23,
                 from /usr/include/boost/smart_ptr/detail/spinlock_gcc_atomic.hpp:14,
                 from /usr/include/boost/smart_ptr/detail/spinlock.hpp:42,
                 from /usr/include/boost/smart_ptr/detail/spinlock_pool.hpp:25,
                 from /usr/include/boost/smart_ptr/shared_ptr.hpp:29,
                 from /usr/include/boost/property_map/vector_property_map.hpp:14,
                 from /usr/include/boost/property_map/property_map.hpp:606,
                 from /usr/include/CGAL/property_map.h:19,
                 from /usr/include/CGAL/boost/graph/properties.h:16,
                 from /usr/include/CGAL/boost/graph/helpers.h:16,
                 from /usr/include/CGAL/Polygon_mesh_processing/measure.h:22,
                 from test.cc:10:
/usr/include/boost/iterator.hpp:10:1: note: ‘#pragma message: This header is deprecated. Use <iterator> instead.’
   10 | BOOST_HEADER_DEPRECATED("<iterator>")

In order to work around the newest set of deprecated header warnings (this
time triggered by CGAL including a deprecated header :-(() I would
otherwise have to add this "#define dance" at various other places.

Instead, it is cleaner to simply give up and define the macro globally.

The configure checks will ensure that the macro is only ever defined if
needed.

In reference to #13910

In order to work around the newest set of deprecated header warnings
(this time triggered by CGAL including a deprecated header :-(() I would
otherwise have to add this #define dance at 5 different other places.

Instead, it is cleaner to simply give up and define the macro globally.

The configure checks will ensure that the macro is only ever defined if
needed.
@tamiko tamiko added this to the Release 9.4 milestone Jun 8, 2022
@luca-heltai
Copy link
Member

/rebuild

@luca-heltai luca-heltai merged commit 38cf3f5 into dealii:master Jun 8, 2022
mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
CMake: add DEAL_II_CGAL_HAS_DEPRECATED_BOOST_INCLUDES check
@tamiko tamiko deleted the fix_compile_warnings_02 branch November 30, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants