Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving external library interdependencies #13764

Closed
drwells opened this issue May 20, 2022 · 0 comments · Fixed by #13823
Closed

Resolving external library interdependencies #13764

drwells opened this issue May 20, 2022 · 0 comments · Fixed by #13823

Comments

@drwells
Copy link
Member

drwells commented May 20, 2022

Previously, I thought that the file names of scripts in cmake/configure established dependencies since we include them in sorted order:

dealii/CMakeLists.txt

Lines 122 to 129 in ed3f42a

#
# Feature configuration:
#
FILE(GLOB _configure_files "cmake/configure/configure_*.cmake")
LIST(SORT _configure_files) # make sure to include in alphabetical order
FOREACH(_file ${_configure_files})
VERBOSE_INCLUDE(${_file})
ENDFOREACH()

However, only about half of the files contain a digit in them (e.g., configure_0_threads.cmake is always first). We also have FEATURE_${_feature}_AFTER and FEATURE_${_feature}_DEPENDS which do error checking for interdependencies.

Is there any reason half of these don't have digits? If not then lets go ahead and add them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant