CMake: Make configure file naming consistent #13823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
approved these changes
May 25, 2022
|
This needs to be rebased. |
Configure file are including and processed in alphabetical order. However, in order to allow for feature dependencies we have to include some configure files before others. We have solved this by numbering some of the configure files in order to force them to be processed before others. This pull requests makes this numbering a bit more consistent by - numbering _all_ of the configure files with a default number of 50, and configure files that have to be processed earlier taking up a number between 40 and 00. - increasing the numbering from one digit to two digits to accomodate a possible future need to adjust the inclusion order a bit better.
tamiko
force-pushed
the
unify_configure_file_naming
branch
from
79a544c
to
58998a2
Compare
|
@kronbichler Rebased. Github is confused. |
drwells
approved these changes
May 26, 2022
kronbichler
approved these changes
May 26, 2022
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
CMake: Make configure file naming consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure file are including and processed in alphabetical order.
However, in order to allow for feature dependencies we have to include
some configure files before others. We have solved this by numbering
some of the configure files in order to force them to be processed
before others.
This pull requests makes this numbering a bit more consistent by
numbering all of the configure files with a default number of 50,
and configure files that have to be processed earlier taking up a
number between 40 and 00.
increasing the numbering from one digit to two digits to accomodate
a possible future need to adjust the inclusion order a bit better.
Closes #13764