Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about cmake Tpetra detection #14372

Closed
bangerth opened this issue Oct 23, 2022 · 2 comments · Fixed by #14455
Closed

Question about cmake Tpetra detection #14372

bangerth opened this issue Oct 23, 2022 · 2 comments · Fixed by #14455

Comments

@bangerth
Copy link
Member

We have the following piece of code: https://github.com/dealii/dealii/blob/master/cmake/configure/configure_20_trilinos.cmake#L230-L254 Specifically, we have this code snippet we want to compile:

          using LO       = int;
          using GO       = unsigned int;
          using GO       = ${_global_index_type};

It is, interestingly, allowed to redeclare the same type via using, but only if the right hand side is the same. It is not allowed to declare it to a different type. In other words, compiling this code snippet will only work if ${_global_index_type} is unsigned int.

Is this a mistake in our cmake scripts? Or am I just not getting what this is trying to achieve?

@drwells
Copy link
Member

drwells commented Oct 24, 2022

Possibly related to #13972.

@tamiko
Copy link
Member

tamiko commented Nov 23, 2022

@bangerth The line should not be repeated - this is a refactoring mistake.

Unfortunately, we have not resolved #13972 yet, meaning this configure check will always fail for any (default configured) Trilinos version after 13.2 because the Tpetra/Kokkos backend need signed ordinals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants