Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static analysis: dealii-git/include/deal.II/lac/la_parallel_vector.templates.h #3360

Closed
bangerth opened this issue Nov 2, 2016 · 1 comment

Comments

@bangerth
Copy link
Member

bangerth commented Nov 2, 2016

dealii-git/include/deal.II/lac/la_parallel_vector.templates.h	59	warn	V728 An excessive check can be simplified. The '||' operator is surrounded by opposite expressions 'val == 0' and 'val != 0'. 

We should address these warnings and errors from the static analysis tool PVS. In response to #3342.

@Rombur
Copy link
Member

Rombur commented Nov 3, 2016

The code is correct. I think PVS got confused because val is a pointer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants