Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check encoding in the CI testers #8076

Closed
bangerth opened this issue May 10, 2019 · 1 comment · Fixed by #9711
Closed

Check encoding in the CI testers #8076

bangerth opened this issue May 10, 2019 · 1 comment · Fixed by #9711
Assignees
@tjhei
Labels
Build system Infrastructure
Milestone
Release 9.2

Comments

@bangerth
Copy link
Member

#7628 introduces a script that checks that we use consistent encoding. We ought to make that a step in the CI infrastructure, possibly coupled to the check that verifies the indentation.
@bangerth bangerth added this to the Release 9.2 milestone May 10, 2019
@kronbichler
Copy link
Member

We have considerably extended the CI checks since the last release, but I have not checked the encoding. @bangerth or @tjhei can you confirm that this issue is satisfactorily resolved?

tjhei added a commit to tjhei/dealii that referenced this issue Mar 22, 2020
@tjhei
CI: check file encoding
d97b8b3 
closes dealii#8076
@tjhei tjhei mentioned this issue Mar 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjhei tjhei

Labels
Build system Infrastructure
Projects
None yet
Milestone
Release 9.2
Development

Successfully merging a pull request may close this issue.

CI: check file encoding tjhei/dealii
4 participants
@tjhei @tamiko @bangerth @kronbichler