correct docu of GridTools::transform() and GridGenerator::cylinder() #10079
Conversation
There was a problem hiding this comment.
I have one request regarding the documentation and one question: Shouldn't we simply add triangulation.reset_all_manifolds() inside the GridTools::transform implementation? This is how I understood the consensus in the issue #8914.
The thing is that at least for translations and rotations it should be reasonably simple to put a manifold that applies a transformation for us between the old manifold and the new one, apart from the difficulties mentioned in #8914 (comment). So this behavior might change in the future if someone is willing to implement it, and putting the reset_all_manifolds() inside the library for the cases we don't know the result seems more consistent to me.
include/deal.II/grid/grid_tools.h
Outdated
| * to the triangulation. If you want to perform refinements according to a | ||
| * manifold description, you should first do the refinements, subsequently | ||
| * deactivate all manifolds, and finally call the transform() function. The |
There was a problem hiding this comment.
I don't think this statement on refinements is true in this generality - it is perfectly valid to refine the mesh after the transformation if one has a manifold for the transformed geometry at hand. So I would state this as
| * to the triangulation. If you want to perform refinements according to a | |
| * manifold description, you should first do the refinements, subsequently | |
| * deactivate all manifolds, and finally call the transform() function. The | |
| * to the triangulation. If you want to perform refinements according to a | |
| * manifold description, you either need to attach the appropriate manifold | |
| * for the transformed geometry and clear possibly old manifolds, or | |
| * do the refinements before the transformation, deactivate all manifolds, | |
| * and finally call the transform() function. The |
There was a problem hiding this comment.
I can incorporate this idea. However, I would reformulate it a bit because the sentence becomes quite complicated now.
|
Regarding your question, I agree principally, but I think we have issue #8914 to discuss these basic decisions and separate PRs to work on solutions. I think here we should focus on the documentation. |
Closes #8920.
Since no changes to the implemented will be made soon, the docu should correctly describe the current behavior.