-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove cuda 8 support #10298
remove cuda 8 support #10298
Conversation
related to dealii#10296
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also clean include/deal.II/lac/cuda_atomic.h
.
doc/external-libs/cuda.html
Outdated
@@ -31,14 +31,12 @@ <h1>Installing deal.II with CUDA</h1> | |||
-DDEAL_II_WITH_CUDA=ON | |||
</pre> | |||
Depending on you system, this may be enough to get CUDA to work. If you | |||
are using CUDA 8 with gcc 5.4, you will need to turn off support for | |||
C++14: | |||
are using CUDA 9 or 10, you might need to turn off support for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might
-> will
only CUDA 11 supports C++17 and it hasn't been released yet.
@@ -47,27 +47,7 @@ namespace LinearAlgebra | |||
inline __device__ double | |||
atomicAdd_wrapper(double *address, double val) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just deprecate this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, separate PR ok?
(will test tomorrow) |
this seems to work now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me.
related to #10296
FYI: @Rombur @masterleinad