Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cuda 8 support #10298

Merged
merged 4 commits into from
May 22, 2020
Merged

remove cuda 8 support #10298

merged 4 commits into from
May 22, 2020

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented May 21, 2020

related to #10296

FYI: @Rombur @masterleinad

@tjhei tjhei added this to the Hackathon 2020 milestone May 21, 2020
Copy link
Member

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also clean include/deal.II/lac/cuda_atomic.h.

@@ -31,14 +31,12 @@ <h1>Installing deal.II with CUDA</h1>
-DDEAL_II_WITH_CUDA=ON
</pre>
Depending on you system, this may be enough to get CUDA to work. If you
are using CUDA 8 with gcc 5.4, you will need to turn off support for
C++14:
are using CUDA 9 or 10, you might need to turn off support for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might -> will only CUDA 11 supports C++17 and it hasn't been released yet.

@@ -47,27 +47,7 @@ namespace LinearAlgebra
inline __device__ double
atomicAdd_wrapper(double *address, double val)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just deprecate this function.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, separate PR ok?

@tjhei
Copy link
Member Author

tjhei commented May 22, 2020

(will test tomorrow)

@tjhei tjhei removed the WIP ⚠️ label May 22, 2020
@tjhei
Copy link
Member Author

tjhei commented May 22, 2020

this seems to work now.

Copy link
Member

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@masterleinad masterleinad merged commit 3136a85 into dealii:master May 22, 2020
@tjhei tjhei deleted the remove-cuda8 branch May 23, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants