Fix conflict with Simplex::GridGenerator #10769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
reviewed
Jul 30, 2020
|
I prefer this over the old namespacing. 👍 |
peterrum
force-pushed
the
simplex_grid_generator_namespace
branch
from
703db4f
to
8f21fc6
Compare
|
I am not sure I understand. I thought that we don't want simplex related functions to show up in doxygen right now. As a consequence, you will need to |
|
I don't really mind if it appears in doxygen as long as there are enough asserts which prevent the usage. |
|
But things that we don't intend to enable yet shouldn't show up in the documentation either. That would just be confusing. |
bangerth
reviewed
Jul 30, 2020
bangerth
reviewed
Jul 30, 2020
peterrum
force-pushed
the
simplex_grid_generator_namespace
branch
from
8f21fc6
to
1f6d5a6
Compare
|
I have moved the implementation in a separate file, added the ifdefs, and fixed the doxygen comment. Thanks for the comments! |
|
/rebuild |
drwells
approved these changes
Jul 31, 2020
|
The new name is verbose but clear and avoids doxygen problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10765.