New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dof_accessor warning #10788
fix dof_accessor warning #10788
Conversation
fixes: ``` /jenkins/workspace/dealii_PR-10786/include/deal.II/base/exceptions.h:1414:72: error: ‘fe_index_’ may be used uninitialized in this function [-Werror =maybe-uninitialized] /jenkins/workspace/dealii_PR-10786/include/deal.II/dofs/dof_accessor.templates.h:284:22: note: ‘fe_index_’ was declared here ```
|
||
if (dof_handler.hp_capability_enabled) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this if is redundant because we exit a couple of lines above otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure that did what you did once. Maybe locally!?
dof_handler.hp_object_fe_ptr[d][obj_index], | ||
ptr); | ||
} | ||
fe_index_ = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fe_index_ = | |
unsigned int fe_index_ = |
OK. I did it here: dealii/include/deal.II/dofs/dof_accessor.templates.h Lines 339 to 429 in ade0b73
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with the one change.
/rebuild |
fixes:
part of #10786