Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MemorySpaceData virtual #10873

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Make MemorySpaceData virtual #10873

merged 1 commit into from
Sep 2, 2020

Conversation

peterrum
Copy link
Member

@peterrum peterrum commented Sep 1, 2020

... and enable a vector-specific destructor of values. E.g.:

dealii/include/deal.II/lac/la_sm_vector.templates.h

Lines 123 to 124 in bfc921d

data.values = {ptr_aligned,
[&data](Number *&) { MPI_Win_free(data.values_win); }};

Needed by #10872.

@peterrum
Copy link
Member Author

peterrum commented Sep 1, 2020

/rebuild

@masterleinad masterleinad merged commit 58ff9b5 into dealii:master Sep 2, 2020
@bangerth bangerth mentioned this pull request Sep 30, 2020
Closed
@peterrum peterrum mentioned this pull request Oct 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwells drwells drwells approved these changes

Assignees
No one assigned
Labels
ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterrum @drwells @masterleinad