Use a virtual destructor with virtual methods. #10879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
Sep 2, 2020
peterrum
added
Reviewed and ready to merge
and removed
Reviewed and ready to merge
labels
|
Those are some interesting failures. I'm investigating. |
|
A general remark. Maybe we could enable some compiler warnings in the the GitHub tests so that we already catch such issues already during the PR. I did that for braces a month ago... |
|
what is the precise warning? |
drwells
force-pushed
the
memory-space-virtual-dtor
branch
from
b6ddb1e
to
39c153e
Compare
|
I have |
drwells
force-pushed
the
memory-space-virtual-dtor
branch
from
39c153e
to
b3f865f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a new warning.