Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace C-style arrays in MatrixFree #10895

Merged
merged 1 commit into from
Sep 6, 2020
Merged

Conversation

peterrum
Copy link
Member

@peterrum peterrum commented Sep 5, 2020

No description provided.

Copy link
Member

@drwells drwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this. Seeing arrray references instead of pointers in function calls makes the code much easier to understand.

Copy link
Member

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is any of this user-facing and as such not backwards compatible? Looks good otherwise.

@peterrum
Copy link
Member Author

peterrum commented Sep 5, 2020

Is any of this user-facing and as such not backwards compatible? Looks good otherwise.

Should be all internal. But let's wait for @kronbichler's opinion!

@kronbichler
Copy link
Member

None of those should be directly user-facing and even the use of internal (implementation-dependent) data structures is unlikely to directly access or pass around C-style arrays.

@kronbichler kronbichler merged commit a203af1 into dealii:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants