EvaluatorTensorProduct::apply_face for higher dimensions #10896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
approved these changes
Sep 6, 2020
kronbichler
reviewed
Sep 6, 2020
| @@ -303,7 +303,8 @@ namespace internal | |||
| template <int face_direction, | |||
| bool contract_onto_face, | |||
| bool add, | |||
| int max_derivative> | |||
| int max_derivative, | |||
| bool lex_faces = false> | |||
There was a problem hiding this comment.
Could you please document the new template parameter?
|
/rebuild |
kronbichler
reviewed
Sep 7, 2020
Comment on lines
300
to
303
| * sorted: lexicographically or deal.II-style (special | ||
| * treatment of orientation 1 in 3D). Per default | ||
| * deal.II-order is enabled. Note: that the deal.II | ||
| * ordering is only working for dimensions up to 3. |
There was a problem hiding this comment.
I would not call it deal.Il orientation but rather right-hand-system numbering or something like that (which is a 3D concept). The idea is to let axis direction wrap around in defining the order, rather than going lexicographically from the faster running tensor index to the slower running one. What do you think?
There was a problem hiding this comment.
What do you think?
I agree. I just did not know how to call it. I have made the change!
kronbichler
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References hyperdeal/hyperdeal#47 and hyperdeal/hyperdeal#48.