Make the tolerance in step-1 relative. #10923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
masterleinad
approved these changes
Sep 16, 2020
tjhei
reviewed
Sep 16, 2020
examples/step-1/step-1.cc
Outdated
| // [round-off](https://en.wikipedia.org/wiki/Round-off_error). As | ||
| // a consequence, we can never expect to compare the distance | ||
| // with the inner radius by equality: A statement such as | ||
| // `if (distance_from_center == inner_radius)` will always fail |
There was a problem hiding this comment.
Suggested change
| // `if (distance_from_center == inner_radius)` will always fail | |
| // `if (distance_from_center == inner_radius)` will fail |
examples/step-1/step-1.cc
Outdated
| // unless we get exceptionally lucky. Rather, we need to do this | ||
| // comparison with a certain tolerance, and the usual way to do | ||
| // this is to write it as `if (std::abs(distance_from_center - | ||
| // inner_radius) |
|
@tjhei -- so done! |
tjhei
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.