step-69: Remove boundary c_ij fix #10926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We compute the boundary normal by averaging the normal over the quadrature points weighted with the shape function. It turns out that this is sufficient to preserve mass and total energy. No change of the c_ij's are needed.
|
@itomasSNL @kronbichler ping |
|
All, I would like to get a review by @itomasSNL on this one 😅 |
kronbichler
approved these changes
Sep 17, 2020
drwells
changed the title
|
/rebuild |
|
|
tamiko
added
Reviewed and ready to merge
WIP ⚠️
and removed
Reviewed and ready to merge
labels
|
@kronbichler @tamiko Now the documentation and the source code are consistent. |
kronbichler
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We compute the boundary normal by averaging the normal over the
quadrature points weighted with the shape function. It turns out that
this is sufficient to preserve mass and total energy. No change of the
c_ij's are needed.