Remove unnecessary instantiation files #10970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #10927, we do not need to instantiate
matrix_free/evaluation_selector.ccany more. Furthermore, since we do not use the degree templates inVectorTools::projectany more, it is safe to compilevector_tools_project.ccwith a single instantiation. This saves quite some time in compiling, aggregated over the full set of files. I checked that the memory consumption with gcc-7 is not more than 1.8G with the new single instantiation file forvector_tools_project.cc(and it compiles in 29 seconds for debug mode and 46 seconds for release mode).