Deprecate hp::DoFHandler. #11171
Deprecate hp::DoFHandler. #11171
Conversation
marcfehling
force-pushed
the
deprecate-hpdofhandler
branch
from
3d8525f
to
8ee41c9
Compare
marcfehling
force-pushed
the
deprecate-hpdofhandler
branch
from
3b292f3
to
aba9e3d
Compare
|
I've found an example in |
|
Just as I wrote these lines, I've found the |
marcfehling
force-pushed
the
deprecate-hpdofhandler
branch
3 times, most recently
from
1ff4958
to
55f90a7
Compare
| DoFHandler & | ||
| operator=(const DoFHandler &) = delete; | ||
| using dealii::DoFHandler<dim, spacedim>::DoFHandler; | ||
| using dealii::DoFHandler<dim, spacedim>::operator=; |
There was a problem hiding this comment.
Not sure whether the copy operator alias is necessary, but it probably won't hurt.
marcfehling
force-pushed
the
deprecate-hpdofhandler
branch
from
02149a3
to
3c91a9b
Compare
|
With the use of constructor aliases, there is no need to wait on a decision for the |
| @@ -630,6 +630,8 @@ class MatrixFree : public Subscriptor | |||
| const std::vector<QuadratureType> & quad, | |||
| const AdditionalData &additional_data = AdditionalData()); | |||
|
|
|||
| DEAL_II_DISABLE_EXTRA_DIAGNOSTICS | |||
There was a problem hiding this comment.
I am wondering if you can write:
template <typename QuadratureType, typename number2, typename DoFHandlerType>
DEAL_II_DEPRECATED void
reinit(const Mapping<DoFHandlerType::dimension> & mapping,
const std::vector<const DoFHandlerType *> & dof_handler_hp,
const std::vector<const AffineConstraints<number2> *> &constraint,
const std::vector<QuadratureType> & quad,
const AdditionalData &additional_data = AdditionalData());The other function should be simply a specialization.
There was a problem hiding this comment.
...and leave out the extra diagnostics flag? Hmm this could work.
There are a couple of tests using the hp-variant in tests/matrix_free. I'll add a commit and we'll see whether the testsuite complains.
|
/rebuild |
Added missing deprecate flags in matrix_free.h. Added DEAL_II_*_EXTRA_DIAGNOSTICS pragmas in matrix_free.h to avoid deprecation warnings during CI.
marcfehling
force-pushed
the
deprecate-hpdofhandler
branch
from
31d1f1d
to
9e16f53
Compare
|
Testsuite is okay with the |
Blocked by #11160.(EDIT: With the use of constructor aliases, there is no need to wait on a decision for the DoFHandler interface)As there is no need for the hp-specialization anymore since #10328, we can deprecate
hp::DoFHandler. @peterrum already left a changelog in that particular PR.In this PR, we actually set the corresponding deprecated flag for
hp::DoFHandler, and adjust the general documentation for the basicDoFHandlerclass. Further, all references to that particular class are removed in the deal.II library (in those entities which are not deprecated).I'll address removing the
hp::DoFHandlerfrom the documentation in a separate PR.Part of #10333.